dapptools icon indicating copy to clipboard operation
dapptools copied to clipboard

Published 20 hours ago • verified publisher icon dapphub

automatic gas estimation

Open ncitron opened this issue 3 years ago • 2 comments

Description

Adds automatic gas estimation to seth mktx if ETH_GAS is not set. Since seth mktx is the underlying for seth send and dapp create, dapptools users will likely never have to input gas limits manually.

Checklist

  • [x] tested locally
  • [ ] added automated tests
  • [x] updated the docs
  • [x] updated the changelog

ncitron avatar Nov 07 '21 05:11 ncitron

Very nice, been wanting this for some time. I have fixed ci on master, could you rebase so we can run it again?

MrChico avatar Nov 07 '21 12:11 MrChico

This should be good to go now. I've made a couple of changes so that instead of directly calling eth_estimateGas, I make all gas estimations through seth estimate (which I made a slight modification to).

I also made sure to do this gas estimation in both seth send and seth mktx. This is because if you use an RPC signer, just adding the estimation in seth mktx is not sufficient.

ncitron avatar Nov 08 '21 03:11 ncitron