Daniel T

Hi @spoo-bar I've reviewed the latest as of right now, I believe. There are still some structural problems. I have commented above but I will rephrase here in summary as...

also linter

Also, don't you need to get rid of this now? https://github.com/dymensionxyz/dymension/blob/31156de13f071d2f333694c8158a07513553dcec/x/rollapp/transfergenesis/ibc_module_canonical_channel_hack.go#L19-L56

@spoo-bar I should have said this earlier, I'm sorry but could you pleas replace the IBCState type with using the existing one which is the same? https://github.com/cosmos/ibc-go/blob/7e7cdbf48bcab9989a53c9c5dcb47b306a5d084d/modules/light-clients/07-tendermint/tendermint.pb.go#L101-L109 Thanks

Hey @spoo-bar I've realized something: https://github.com/dymensionxyz/dymension/blob/efaa792aacc8e420ebc995f802ac7968967d8b21/x/lightclient/ante/ibc_msg_update_client.go#L79-L81 This is not secure, because we cannot trust proposer hash We need to save the ~next~ validators set hash. If this turns out to...

``` Instead of having IsRotating(){ return nextProposer!=nil } IsRotating(){ return currentProposer().NoticePeriodTime < now } ``` ? Then we don't need nil/empty type in nextPRoposer?

>I don't like it. It's not hermetic enough. I'm leaving it as Rotation is started == NextProposer is defined as this is undisputed truth. It's just very unintuitive, because there...

add a tagline to the rollapp metadata (limited to 64 chars)

done but forgot to link PR

Gonna note some things here to not lose track. - [ ] [ADR](https://www.notion.so/dymension/ADR-x-Rollapp-light-client-8aad2cfedccc4b4185cff58287c902bf#4cc4703bb6d94a33b0eb3fa456506d4a) needs a fleshed out section on backwards compatibility and upgrades. There is already a [research](https://www.notion.so/dymension/Rollapp-Light-Client-Validity-Vanilla-TrustPeriod-42c84ea2e9fd4b67a53f3636f7ec5687?pvs=4#1e99212bebfe4805a81bb0a12669ddbe) section on...