Daniel T
Daniel T
``` ight provider light block: client provided bad signed header: expected validator hash of header to match validator set hash (A130487864D20F55E7AB5876931AF389088B94E29D74EBE258B75D54CFE7493A != ADC9E5E48253EE56F29FA95327C3CDB5B7DC5FC54E4DF722E97DF66D7E066F37) ```
For incentives and lockup there is still GetSigners() in types/, and the eth one goes through a different ante handler afaiu
> explicit GetSigners() is deprecated, it should have been defined in the protos It's not it still works I think
> which expected to be called under authz. I'm checking what annotation required for this case you put 'inner' Michael, it's right? @mtsitrin
In fact, from looking v2.5.2 there doesn't seem to be any support for updating with concern about voting power changes. The relayer just always tries to update the light client...
Side note: What is this code doing? https://github.com/cosmos/relayer/blob/3b9ec008999973469aeab4bbdbcb44ff4886b8b8/relayer/processor/path_processor_internal.go#L702-L710 Seems it's wrong, it checks `bytes.Equal(dst.clientTrustedState.IBCHeader.NextValidatorsHash(), ibcHeaderCurrent.NextValidatorsHash())` on 704 which doesn't make sense
Seems like a nice to have but not urgent? Wdyt @srene ?
> u call err := m.ensureAccount(ctx, operator) here and err := k.ensureAccount(ctx, args.FundsSource) in .fulfill Yes, this is as on main branch
> I think in fulfill it's called for lp, not operator there are two calls yeah, to match main