Dan Vanderkam

Results 371 comments of Dan Vanderkam

I was able to run this rule over an existing code base of mine. The results were pretty interesting! There were 36 violations of the rule. Many of them looked...

I'd like to test this on my repo, but I'm getting a ton of errors from `git pull && yarn && yarn build`. Any ideas?

I am getting this error consistently. Here's my shell session: ``` (09:04:04)danvk@mbp:~/github/typescript-eslint(no-unnecessary-type-parameters ✔) yarn cache clean ➤ YN0000: Done in 0s 181ms (09:06:37)danvk@mbp:~/github/typescript-eslint(no-unnecessary-type-parameters ✔) yarn ➤ YN0000: ┌ Project validation...

(A fresh clone worked, so there's definitely some sort of bad state here.)

> @danvk please can you see if running > > yarn nx reset > > and then rerunning the install resolves the issue? @JamesHenry Running `yarn nx reset` and then...

I was able to build this and run it on some of my code! Here's the one false positive I found: ```ts type AllValues = { [P in keyof T]:...

> Question: what's the motivation for counting the references to `T` for the underlying generic type definition? For example, in the case `f(): G`, I would very much prefer it...

Thanks for taking over this PR and getting it merged, @JoshuaKGoldberg! I'm definitely curious to see what sort of feedback we get on it.

I was able to work around this by pinning to some old versions of react-spring using Yarn's `resolutions` in my `package.json`: ``` "resolutions": { "@react-spring/three": "9.0.0-rc.3", "@react-spring/web": "9.0.0-rc.3", "@react-spring/core": "9.0.0-rc.3",...