Dan Vanderkam

Results 371 comments of Dan Vanderkam

Here's another one: [1508179](https://digitalcollections.nypl.org/items/63401f40-c5ce-012f-d426-58d385a7bc34#/?uuid=510d47e2-00bc-a3d9-e040-e00a18064a99).

@aviv-skillset can you share the full command that you ran? It may just be a matter of updating from: pg-to-ts generate -c postgresql://user:pass@host/db -o dbschema.ts to pg-to-ts generate -c 'postgresql://user:pass@host/db'...

@aviv-skillset looking at the [pg-connection-string](https://github.com/brianc/node-postgres/tree/master/packages/pg-connection-string#tcp-connections) page that you referenced, you may need to URL encode your password (and possibly the other fields) to make this work. So using your example:...

There's some logic in [blanket-stub-jsx.js](https://github.com/danvk/mocha-react/blob/f35af095eae75a75d3d3b01bc4fcfd8a0bd6e6b8/tests/blanket-stub-jsx.js#L31): ``` javascript delete require.cache[normalizedFilename]; // might not be stubbed in the future. ``` which looks like it didn't make it into [jsx-stub-transform.js](https://github.com/danvk/mocha-react/blob/f35af095eae75a75d3d3b01bc4fcfd8a0bd6e6b8/tests/jsx-stub-transform.js). Want to try...

I incorporated your change. If you'd like to send me a pull request with a regression test, I'd be happy to merge it. I'm concerned that this solution only works...

@adjavaherian could you try moving the `delete require.cache[filename];` out of the `if` statement in `jsx-stub-transform.js`? re: node vs. browser, they're only isomorphic if you assume all browsers work exactly like...

@jxm262 that may be possible, but I don't believe React exposes any way to do it. Here's [another project of mine](https://github.com/hammerlab/pileup.js/) which uses Mocha + PhantomJS for testing.

Hi @rubengmurray, thanks for the contribution! Could you add some tests for this? A unit test and also an integration test? For general cleanliness of the output, it would be...

Hi @rubengmurray -- what errors are you getting? How are you running the tests? Do you have an instance of Postgres running that the tests can connect to? If not,...

Thanks for digging into this @rubengmurray. Your docker-compose idea makes sense to me. I'd suggest removing the UUIDs since they're somewhat incidental to the test and I didn't realize they...