Dan Virsén

Results 20 comments of Dan Virsén

I added a simple log in my test application for the `ACK` event listener to illustrate that it's not triggered in the 3PCC call. It also shows that the B2BUA...

The SIP URIs you tried aren't valid. Have you tried with `sip:trunk.mydomain.com:8088;transport=ws`?

Not OP, but I was in the process of updating drachtio-srf when I noticed this and found that there was an issue created only hours ago. This is the PR:...

I created a new branch in my fork for this. Could you please help me test? You should be able to just replace the version with the path in your...

I have added all missing (I hope) middleware methods for "srf".

Yes, that's true. I did the changes blind but when I tested my changes I did get some "implicit any type" errors and other warnings that some types weren't available....

Since the default export is the class Srf, I use it like this: ```typescript import Srf, { CreateUACOptions, Dialog, SrfRequest, SrfResponse } from "drachtio-srf"; const srf = new Srf(); ```

I was thinking that it might make sense to move the types to the DefinitelyTyped project instead of having them in this repository. https://github.com/DefinitelyTyped/DefinitelyTyped Until then hopefully my PR fixes...

I have added a comment to your PR but overall I think it looks good. The bigger question still remains for me though: Should the types be in this repository...