dantleech

Results 954 comments of dantleech

@sebastianbergmann and I had a call and decided to simplify the approach in the PR to support the bare minumum glob syntax and that it would be part of the...

hi, no not yet, need to find some time

would you be option to using a third-party package, namely [webmozarts/glob](https://github.com/webmozarts/glob)? We could evaluate it with that implementation at least I guess.

I think that "constant" case would be different - and it doesn't sound like a refactoring that makes the code objectively better? this would be more about removing useless temporary...

Hey, basically this is a proposal - and it should work but would need more time invested in testing, exploring the behavior and perhaps adding more test cases and as...

is `/home/user/test.php` a real path or one you sanitised? as it would be very unusual to be working in the root of your home directory... I assume `test.php` is a...

I mean, it's not moot if it's **not** the file you have open in your editor when you apply the fix - is it the very same file you have...

the codes are hard-coded here: https://github.com/phpactor/phpactor/blob/7f1a270bff74a14db65ce200f9a19c84a972a733/lib/Extension/Logger/Formatter/PrettyFormatter.php#L8 we should probably switch to using the ConsoleOutput from the ConsoleExtension...

so .... one (phactor-side) solution here is to make Phpactor provide a textedit? If it's a Helix issue relating to `insertText` without a TextEdit could (wild guess) it be related...