dantleech

Results 876 comments of dantleech

hm, we should ensure that Phpactor _only_ runs cs fixer with a single process, but with a (new) command line flag we also need to detect the version, which isn't...

> config flag / env var for PHPActor integration that would enforce usage of --sequential yeah, the simple option would be to allow options to be configured (as we do...

Shouldn't do, feel free to make a PR ideally with a test

at this point it may be worth re-evaluating the PHPStan docblock parser, the original reason for writing an own parser was due to real-time performance, but as I recall the...

I think a starting point would be the `WorseReflection` package it should be as "easy" as implementing the `lib/WorseReflection/Core/DocBlock/DocBlockFactory.php` class - below is essentially the entire integration with the DocblockParser`:...

This issue is rather that Helix hasn't supplied the `rootUri` in the initialization request. Neither Neovim nor VS code start Phpactor on arbitrary single files outside of a project root...

actually - I lie. VS code produces the same error - so probably Phpactor should support a rootless mode ..

> probably because it's a very huge codebase Phpactor has performance issues with large, complex, files. You might be able to improve performance by disabling [diagnoatics on update](https://phpactor.readthedocs.io/en/master/reference/configuration.html#language-server-diagnostics-on-update). The code...

some before/after benchmarks: - `./bin/phpactor worse:analyse lib/WorseReflection` - `./vendor/bin/phpbench run lib/WorseReflection --variant=PhpUnitReflectClassBench` (maybe see if any othre benchmarks are sensitive to this change)

> This also might be replaced with phpstan docblock parser we can leave that as is for now and focus on worse-reflection which is where most of the value comes...