dantleech

Results 890 comments of dantleech

I haven't worked on this for years, feel free to investigate I'm happy to review any PR

feel fee to make an MR :slightly_smiling_face: i guess (?) it's fairly easy

> Yes this increases the size of the index but it will drastically reduce the amount of work reference finding takes AFAIK we do index the class name (the `MemberRecord::$containerType`)...

> have not idea when and how the list of references should be restricted accordingly to the visibility. basically you don't need the indexer here, you only need reflection. so...

For private and protected the speed can be i increased significantly by not using the indexer at all... which is exactly what the non LSP version does (and it's reliable...

Problem is that we then pull in a huge number of dependencies and I think increase risk of cross-package contamination. Merging implementation extensions into implementation packages is still keeping strong...

I can't reproduce this. Unittled files shold be stored as `untiltiled:something` there _should_ never be a case where a path is empty with the `file://` scheme

honestly I don't know, (how) does this happen in real life?