Daniel Thwaites

Results 349 comments of Daniel Thwaites

Does this not inherit our existing GTK theming, since it's based on GTK? If not, it looks like the widgets are created mostly from scratch by the user, which would...

In the future this could integrate with #210 to track which applications support live theme reloading.

Stylix should try to support changing the theme immediately (without restarting the application) after a rebuild, wherever this is possible. However, I agree that there is no need to provide...

> you should add a testbed I added this. For some reason the application doesn't autostart or show in the menu, but it can be launched from the console.

@trueNAHO please can you check whether the conversations from [your previous review](https://github.com/danth/stylix/pull/951#pullrequestreview-2699629597) should be resolved :))

Yes, that seems reasonable. We could use [`sponge`](https://manpages.ubuntu.com/manpages/focal/en/man1/sponge.1.html) to avoid creating a temporary file. We'd also have to handle the case where the file hasn't been initialised yet.

Can confirm, this is now working. However, some of the text is difficult to read with a light theme: ![Screenshot of file browser](https://github.com/user-attachments/assets/7cf8aff0-49f4-481e-acbc-1eb85285cfe6) I couldn't find which part of the...

> Im not sure how to do this programatically but we'd need to change this with the polarity. All of the colors should be coming directly from the theme; the...

I can confirm this happens for my theme too. I'm not sure where it gets the color from - whether it's configurable somewhere, or if the calendar app tries to...

We might want to update these colors in the Stylix code if it doesn't break other things - might also be related to #1560