Daniel Thwaites

Results 349 comments of Daniel Thwaites

@unlux I believe the correct name for the theme may be `Adwaita`, not `Adwaita Cursors`: ```console [danth@horologium:~]$ nix build nixpkgs#adwaita-icon-theme [danth@horologium:~]$ head result/share/icons/Adwaita/index.theme [Icon Theme] Name=Adwaita ``` Can you check...

The Do not Disturb knob is because it's a separate SVG file and we currently only change the CSS. (Support could be added for this.) I will look into why...

I believe the hover color is wrong due to this transformation: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/f22fc3c5a94aeb83b5898074945682f5cc86429b/data/theme/gnome-shell-sass/_drawing.scss#L193 We don't set `$variant`, so presumably the color is always being darkened even on a dark scheme. Ideally...

Basically, we don't always know the correct value. Our `polarity` option only guides the default palette generator in what it should produce: it defaults to `"either"`, and if the user...

> In that case, we can consider this stable, and I am fine with adding this, if it fixes the issue. We would have to use the hacky approach to...

This feels out of place since the rest of `mkTarget` depends on that option existing, if this isn't a common scenario then we could just leave `gnome-text-editor` without `mkTarget` for...

When this is complete we can also remove the "Maintainer CC" section from the pull request template

> do you think the current MAX_MAINTAINERS=5 approach is a reasonable heuristic to avoid accidental pings? Yes, this seems reasonable. A single module having more than 5 active maintainers seems...

> Wait until we migrate to nix-community, and create a target maintainers team @zowoq is working on automatically adding our maintainers to a team in nix-community, see https://github.com/nix-community/infra/pull/1837

I've updated the permissions on the app, sounds like @zowoq needs to approve the changes before it takes effect.