Dan Ignatoff
Dan Ignatoff
Hi, it looks like this PR has gotten stuck. I took a stab at adapting all of the tests that were added for the char*+size versions of the functions to...
thanks, I opened a PR against the main repo here: https://github.com/zeux/pugixml/pull/633
I am in the process of adding the remaining functions, but I wanted to double check the intended behavior when the string_view or char*+size contains a null in the middle...
When invoking a setter, having any flow that retains the "extra" data after the first null may be a footgun for users -- users may write code assuming that their...
The change to pugixmlconfig.hpp accidentally broke the VERSION variable in the Makefile, I stumbled into this when attempting to update documentation for the new overloads. I have a draft PR...
@ax3l it looks like there are some automated tests in `Examples/Tests/reduced_diags`, but they are failing for me locally (running on CPU on mac): ``` $ ctest --test-dir build -j 4...
@ax3l Okay, I just removed the WIP tag, I think this is ready for proper review.
> I'm curious, how do you handle the case with moving window then? Is the probe in the reference frame moving with the window, which means it gets shifted with...