Daniel

Results 19 comments of Daniel

What's up with this build test? The proposed patch doesn't affect any of the failing Python code.

Were multiple commits, because I had forgotten coverage and black. I squashed them together, thus the force-push.

I reverted the `username` → `name` changes, added a decorator to check the `*args` and added a test for the assertions. I didn't use the decorator in `templating.py`, because I'm...

Hi @blueyed , thanks for the review. I'm unsure about the procedure here. Github was nagging about the "Changes requested" by @tomchristie , so I clicked "request re-review" to get...

I replaced the decorator with the asserts and the type check: f4f4cd1f7843e0e6f02fdc4b382facc671accea6

@Kludex Sorry, had no time before the holidays to get into this. Patch is rebased. Thanks for waking this old issue up.

@tomchristie could you approve the workflow to run?

Branch is up2date with encode/starlette→master.