Dan Torrey
Dan Torrey
@kingzacko1 @ryan-carroll-graylog Thanks for the additional reviews. I think I have addressed all points of feedback. I also just pushed up https://github.com/Graylog2/graylog2-server/pull/13018/commits/854695a6d552552840ab9273f0ffc13d9dd4d19e and https://github.com/Graylog2/graylog-plugin-enterprise/pull/3803/commits/f98c14cf3f1a2e06035d00ad49c23b1c75f78007 in the related PR that ensures...
@ryan-carroll-graylog @kingzacko1 FYI, I just pushed up https://github.com/Graylog2/graylog2-server/pull/13018/commits/1fbf9fae2282b5c6deb64bcfe062d79cde222d91, which reverts the default index set creation migration back to it's original contents (matching `master`). That migration is unique, since back a...
Thanks for all of the time and efforts reviewing this @ryan-carroll-graylog and @kingzacko1! I've just pushed the final update to the change log. I will plan to merge this as...
@boosty Thanks for the review and feedback. I've addressed both points. Can you please take one more look to make sure all looks ok? I have also added a test...
@ryan-carroll-graylog @kingzacko1 When you have some time, can you please review the latest changes? Mostly just updates to the change log and upgrade notes + defaults.
Thanks the the feedback @boosty! I've cleaned those up.
Unless any other feedback is received before, I will plan to merge this PR on Monday.
> I might have missed the conversation, but didn't we want to prefix the default settings with `default_` and use the JadConfig fallback property to keep backward compatibility? Thanks for...
We have since identified that these properties are needed for the initialization of index sets (and the default) for newly created installations (in the case that it is desired to...
@ryan-carroll-graylog @kingzacko1 Nice find! Thanks for the tip. Just added that fix, and it seems to work.