Dan Torrey
Dan Torrey
@Graylog2/secdev After several iterations, and some requirements adjustments, this is nearly complete and ready for some feedback. There are a few small tasks left (described above), which I will finish...
This PR is now complete and ready for review. I will be adding tests shortly. I've added a few additional reviewers for a few extra sets of eyes on this,...
> Found a small bug when testing. > > * Change Rotation Strategy to `Index Time` > ... Thanks @kingzacko1! Great find. That was a really interesting bug. I have...
@kingzacko1 @ryan-carroll-graylog I think I have addressed the recent feedback, so I think this is ready for another look.
> some indexes took the configuration file values and some didn't Thanks seeing that @ryan-carroll-graylog. That is definitely an issue. I found the cause and will fix it.
We will need to work on optimizing the affected application paths. I will work on gathering a list of all areas that need to be updated and will document those...
I agree with the solution suggested above by @bernd. I believe this is a common pattern for performantly handling collections of an indeterminate size. I also think it is ok...
I believe we will need to hide Illuminate-scoped adapter and caches on the Create/Edit lookup table page. These lookup tables are considered to be read-only, and can come/go with Illuminate...
@zeeklop @simonychuang I think I had originally suggested disabling the buttons, but, I was checking, and it looks like there might already be a convention in Graylog for hiding buttons...
Thanks for the additional feedback @kingzacko1! I'll clean those up. @ryan-carroll-graylog I have been working on getting consistency among the system-created indices. I think I have almost made it through...