Danny Willems

Results 171 issues of Danny Willems

I think we do not need columns for the round constants. It is well-defined by the Keccak instance, and static. _Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1558#discussion_r1430165407_

Optim: as it is fixed, we could have it static somewhere. It will be in the binary directly, and not in memory. _Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1558#discussion_r1430162743_

As discussed, maybe it can be simplified later as the new state is only used temporally. Opening a follow-up. _Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1552#discussion_r1430132302_

Minor quip: shouldn't the format follow the `snapshot-fmt` CLI argument? _Originally posted by @rbonichon in https://github.com/o1-labs/proof-systems/pull/1523#discussion_r1425375789_

Nit: ` - Env::constant(0)` can be removed. Will do it later. _Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1497#discussion_r1422747159_

For a follow-up: migth raise exception, see https://github.com/o1-labs/proof-systems/issues/1512. Should we constraint it is greater than 0? Not sure as it would ask to read a huge value in `Fp` `(order...

For a follow-up (as we do not have to atm): support exceptions for lwl/lwr, see spec. _Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/issues/1494#issuecomment-1850278238_

Nit (and not only for this PR): we should use double-quotes. As we do have some (minor) bash scripts, we should start using a shellcheck. _Originally posted by @dannywillems in...

It's not the proving that fails, it's the setup. You'll need to update your test, and perhaps the framework to have a `setup_err` helper _Originally posted by @mrmr1993 in https://github.com/o1-labs/proof-systems/pull/1454#discussion_r1418062942_

![image](https://github.com/o1-labs/proof-systems/assets/6018454/5cc7775f-98b3-490f-b812-8ed2bcc764ff) there are more apparently _Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1420#discussion_r1417139931_