Danny Willems

icon indicating a website link https://dannywillems.github.io icon indicating an email [email protected]

icon company LeakIX icon location Mostly Belgium, but often moving icon location If we use « it is not rocket science » to describe something easy, what if you are a rocket scientist and find your job easy?

Results 171 issues of Danny Willems

MSM/Serialization: improve bitmask_be function for cross-limbs masking

I am thinking about a better interface where you could just bitmask certain bit positions from a biguint or foreign field element instead of the limbs for less error-proneness. Specially...

MSM: check that the last 8 bits is zero in serialization circuit

Use into_par_iter: mvlookup

I haven't used `rayon`, but what's your rule of thumb on using parallel iterators here? Why this one is not `into_par_iter()` for example? _Originally posted by @volhovm in https://github.com/o1-labs/proof-systems/pull/1827#discussion_r1495624022_

Would be nice to have a comment that `numerator` is multiplicity.

1 comment

Would be nice to have a comment that `numerator` is multiplicity. _Originally posted by @volhovm in https://github.com/o1-labs/proof-systems/pull/1807#discussion_r1495604721_

Agree, good to have it though. Maybe could be a `Random` instance instead of just an `impl` method.

Agree, good to have it though. Maybe could be a `Random` instance instead of just an `impl` method. _Originally posted by @volhovm in https://github.com/o1-labs/proof-systems/pull/1807#discussion_r1481663008_

Potential suggestion for the future: if possible let's make it generic, e.g. instead of `enum` implement a trait and then pass concretely used separately defined tables into the prover.

Potential suggestion for the future: if possible let's make it generic, e.g. instead of `enum` implement a trait and then pass concretely used separately defined tables into the prover. _Originally...

Add mdbook-linkcheck

3 comment

Could you please change it to `[Extended Lookup Tables](../kimchi/extended-lookup-tables.md)`? Also do we have some mechanism to check broken references? Like https://docs.rs/mdbook-linkcheck/latest/mdbook_linkcheck/ _Originally posted by @volhovm in https://github.com/o1-labs/proof-systems/pull/1346#discussion_r1410394956_

Reorganize SRS structure/type/trait

Would be nice to add more documentation. It is not enough to say "for now needed by snarky-rs". For which reason it is needed? _Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1716#discussion_r1457951974_

Duplicated field preimage_key. The preimage key is represented as a non-MIPS register in the field `registers.preimage_key`, stored in chunks of 32 bits.

It is duplicated. The preimage key is represented as a non-MIPS register in the field `registers.preimage_key`, stored in chunks of 32 bits. _Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1687#discussion_r1453540674_

Should we also check the hash type? (i.e. is `0x02`, `0x01`). It is indicated by the hint syscall IIRC. Maybe it has to be checked in the MIPS world/turing machine.

Q: should we also check the hash type? (i.e. is `0x02`, `0x01`). It is indicated by the hint syscall IIRC. Maybe it has to be checked in the MIPS world/turing...