dannygonzalez
dannygonzalez
Just an update, I got it working by updating the Jacoco version to 0.8.6 in pom.xml. Also I had to use Java 8 rather that Java 11 to run the...
/signed I have signed the Oracle Contributor Agreement today. Have not received back any confirmation yet though.
> hmm ... wouldn't the change violate spec of adding listeners: > > > If the same listener is added more than once, then it will be notified more than...
The listeners are called back in the order they were registered in my implementation although I didn’t see this requirement in the spec unless I missed something. The performance unregistering...
@kevinrushforth just a note to say there are other ExpressionHelper classes (i.e. MapExpressionHelper, SetExpressionHelper and ListExpressionHelper) that also use arrays and suffer from the linear search issue when removing listeners....
Replying to @nlisker and @kevinrushforth general comments about the memory consumption of using a LinkedHashMap: I agree that at the very least these should be lazy initialised when they are...
Even though the order of notifications is unspecified, the following tests fail if we use a HashMap vs LinkedHashMap i.e. the notifications are not in order of registration: ``` test.javafx.scene.control.TableViewTest...
> Hmm .. personally, I would consider changing such a basic (and probably highly optimized) implementation used all over the framework is a very high risk change that at the...