Danny Goldstein

Results 28 comments of Danny Goldstein

this is on our roadmap, planning to get to it this quarter. On Tue, Jul 13, 2021 at 11:56 AM Chris Van Pelt ***@***.***> wrote: > Not yet but we're...

Hi @lukas, We are moving the sweeps code that is present in both anaconda and CLI to a centralized repository with its own CI that both the CLI and anaconda...

i think the coverage calculations are a bit stingy here, almost all of the lines that are marked not covered are actually being executed in the internal proc

@KyleGoyette i added a test that hits this case, I don't think it will be counted for coverage though since it is running in the notebook.

@KyleGoyette verified that this test fails on master and passes on the PR branch

Yes this is not good, we should allow PK mutations. Currently our order of ops is: 1. Check for duplicates. 2. Mutate. 3. Commit. Perhaps we can fix this by...

![image](https://cloud.githubusercontent.com/assets/2769632/25419542/1ed94354-2a08-11e7-863b-b757459847db.png)

Here is what the JWST website shows: ![image](https://cloud.githubusercontent.com/assets/2769632/25446918/f987ed16-2a67-11e7-8df0-30d88d79598d.png) And here is sncosmo: ![image](https://cloud.githubusercontent.com/assets/2769632/25446949/12ed5aac-2a68-11e7-9864-08dfe842ab13.png)

The hst throughputs also appear to be incorrect. here is wfc3ir from the hst website ![image](https://cloud.githubusercontent.com/assets/2769632/25548074/87361490-2c1f-11e7-99d1-f34fc05635a8.png) and here is what is on sncosmo ![image](https://cloud.githubusercontent.com/assets/2769632/25548082/916a327a-2c1f-11e7-8134-4142eab2ca46.png) looks like sncosmo is overestimating the...

Yes. Could it be that sncosmo is only including the filter transmissions and not the full instrument throughput? If so i think we should make it standard to make the...