Danny Andrews

Results 16 comments of Danny Andrews

I agree with @jamiebuilds on this one. Nested context blocks make tests horribly complex to read. You should always favor extracting common setup into a helper/factory which can be called...

I'm not able to reproduce this. Can you paste the code which is causing the issue?

Seems like an obvious solution to this problem is to run this library through webpack before publishing. Then consumers don't have to worry about setting up their build environment to...

p.s. You can reproduce this error by changing: ```js 'plugins': [[plugin, { 'id': lodashId }]]` ``` to ```js 'plugins': [[plugin, { 'id': lodashId, 'cwd': './' }]] ``` [here](https://github.com/lodash/babel-plugin-lodash/blob/master/test/index.js#L32)

This is siiiiiick. Any updates?

@tf I have exactly the issue you describe. For me, the specificity issue doesn't bite me, it's more of an inconvenience when developing as I have tons of duplicates of...

Okay, never-mind, this breaks accessibility. Do you have any thoughts on how to handle the empty-list problem, though?

I updated the PR to set tabindex to -1 when there are no items in the drag zone.

Not a problem. Yeah, that's a fair point. I wonder if we could do away with adding a tabindex to the dragzone altogether and add `aria-describedby` to each of the...

Any update on this? The lack of line length indicators on the desktop app makes it arduous to use as I have to copy and paste commit messages into an...