Dan Marsden
Dan Marsden
It's generally considered bad practice to include your own version of the ca-cert bundle. Can you please look at removing this from your codebase? I can see how it might...
Moodle core unit tests fail when installing the mod_hvp plugin. The fix seems to be in the upstream h5p class already: https://github.com/h5p/h5p-php-library/pull/68 The fix for the h5p plugin just needs...
The objectfs schedulded tasks should not generate reports/run tasks if objectfs is not actually configured/enabled.
There has been a move away from using the terms blacklist/whitelist - and to "allow list" "deny list" we should be changing these setting names and associated strings in objectfs....
https://github.com/catalyst/moodle-tool_objectfs/commit/ea0ef92552ad47ad1667c7baf97944dc16b2030f#diff-4505b1552d3257e51887561a933ba909a3480650c1758488886c36cedb4f780fR248
This gave me some "Oh crap!" reactions....  We should hide that record from view until the task is complete.
Looks like you need to update the travis-ci config so it runs your master branch with newer version of Moodle too. I'm seeing the following error in a 3.5 site...
There was 1 failure: 1) mod_attendance_external_testcase::test_get_session_with_group Failed asserting that 0 matches expected '266000'. /var/www/html/mod/attendance/tests/externallib_test.php:207 /var/www/html/lib/phpunit/classes/advanced_testcase.php:80 phpvfscomposer:///var/www/html/vendor/phpunit/phpunit/phpunit:97
Moved from: https://tracker.moodle.org/browse/CONTRIB-4803 Use case: Professor configures attendance to award 1 point for every present and 0 points for every absence. However, professor allows up two absences without penalty (freebies)....
When a session uses auto-marking based on activity completion of another activity - we should allow the attendance to be marked immediately rather than waiting for the session end date.