Dan Luu

We assume that the dedup buffer is 0 when we start to use it and that we'll clear it during normal operation. If we catch an exception and continue, that...

ABI: clang assumes that values passed in are already sign-extended or zero-extended

2

1. I get the following failure when I use run the integrated NativeJIT tests: ~~~ /Users/visualstudio/dev/temp/BitFunnel/NativeJIT/test/NativeJIT/FunctionTest.cpp:508: Failure Expected: expected Which is: 5794 To be equal to: observed Which is: 11426...

20% of query execution time spent in SimpleResultsProcessor::FinishIteration

2

This is basically looping over the `uint64_t` accumulator and looking for 1s. It's possible we can get some speedup here by using an instruction or intrinsic that gives us the...

When we ingest documents, we spend 20% of our time inside `DocumentFrequencyTableBuilder::OnTerm`, plus some time getting the lock for the table.  This is with a script file that's a...

Relatively large amount of time spent in SimplePlanner destructor

1

We appear to be spending roughly 3.5% of our time in SimplePlanner in the destructor.  This may not be the lowest hanging fruit right now, and it's possible that...

DiagnosticStream::IsEnabled curiously expensive?

1

If you believe the `Instruments` profiler, my machine spends `3.78s` running `ByteCodeInterpreter::RunOneIteration` when querying chunked1 with the excel-modified DocFreqTable. `370ms`, or 10% of that time is allegedly spent inside `DiagnosticStream::IsEnabled`....

Bin packing algorithm maps most or all of the same rows to consecutive terms

1

We've already discussed this; just filing a bug so that we're tracking this somewhere. Here's an example of three consecutive terms, two of which share all but one row, and...

We specifiy `project(name)` and not (for example `project name CXX C`).

#117 is now fixed, but the issue could have been prevented by passing ownership around appropriately.

TaskPool not RAII because explicit call to Shutdown is required?

2

The private members are ~~~ // TODO: Convert ThreadManager to use std::vector std::vector m_threads; std::unique_ptr m_threadManager; BlockingQueue m_queue; ~~~ It's possible that completing the TODO would make TaskPool RAII.