Dan Luu

Signed testing

1

Should we have better coverage for signed? Most of our tests are against `uint`.

Our current system is a very simple manual hack. We should have some way to automatically extract known-good code and put it into our docs.

This was originally implemented the way it's done in the existing code because variadic templates weren't available in VC++ when the project was started, and on Windows the first four...

X64CodeGenerator.h: ``` // TODO: Move this class to a separate header ``` Note that `Ios` stands for `iostream`

Should we have better coverage? ``` // Test register save/restore across call. // Caller save volatiles // Test call register indirect. // Test that tries all permutations of parameter from...

We're missing coverage of some conditionals.

inc/NativeJIT/Nodes/ParameterNode.h ``` // Integer parameters are passed in RCX, RDX, R8, and R9. // Use constants to encode registers. See #31. #ifdef NATIVEJIT_PLATFORM_WINDOWS const uint8_t idMap[] = {1, 2, 8,...

inc/NativeJIT/Packed.h ``` // TODO: This class and PackedMinMaxNode should probably move from NativeJIT to BitFunnel.Library. ```

inc/NativeJIT/Nodes/Node.h ``` // Increments the number of node's parents that will evaluate the node // through the Node::CodeGen() method. The node will be evaluated // only once, but the result...

``` // TODO: Perhaps this should return a Data*. // If nothing is displaced, returns nullptr. // Otherwise returns Data* for displaced. template void ExpressionTree::FreeList::Allocate(unsigned id) { ``` We believe...