Dan Luu

Re: today's discussion. Where do we have to make changes if we 1's comp a hash to avoid fact collision? 1. Term constructor 2. AddTerm (where we create a phrase)...

There's been a TODO on this in the code since at least Jul 2016 (621d537606d5abca4292dc29575bf2fcc8b76357). This is one of the cleanup items that's waiting on a comment from you.

Also, see #208

Here are the preliminary results for the quick and dirty fix for this problem. The graphs below are raw number of false positives. As before, the x axis is term...

(1) seems sub-optimal given that we're planning on bundling NativeJIT into BitFunnel via either git subtree or git submodule. If there's no way to get BitFunnel without NativeJIT, (1) seems...

Good catch! We obviously don't include NativeJIT this way so the it just happens to do this by coincidence since we weren't thinking about this when we put together the...

Below the comment, each extern line runs a constructor to define a register (like al). Constructors of random top-level things aren't always run first.

The bulk of this was fixed by dda5ee875d13bcc643cc463a8e34998729598c4c, although we still include TestSetup.h for scaffolding.

@MikeHopcroft What do you want to do with the TestFixture stuff that remains?

Hi! That's a great idea! The `Parser` example in the `Examples` directory could probably be modified to do that, but it doesn't support all of those functions right now. I'm...