NativeJIT icon indicating copy to clipboard operation
NativeJIT copied to clipboard

Decide what to do with files in inc/Temporary

Open MikeHopcroft opened this issue 8 years ago • 1 comments

These are allocator interfaces that will also be used in BitFunnel. Options seem to be

  1. Maintain separate versions, one in the NativeJIT namespace, and one in the BitFunnel namespace.
  2. Make both NativeJIT and BitFunnel take a dependency on a 3rd repo that provides these interfaces.
  3. Make BitFunnel depend on NativeJIT for these interfaces.

MikeHopcroft avatar Apr 25 '16 18:04 MikeHopcroft

(1) seems sub-optimal given that we're planning on bundling NativeJIT into BitFunnel via either git subtree or git submodule. If there's no way to get BitFunnel without NativeJIT, (1) seems like it's asking for trouble without really having any upside.

I don't have a preference between (2) and (3). (2) seems "better" in some abstract sense, but my vote is for whichever is easier since I don't think it's going to matter much.

danluu avatar Sep 05 '16 04:09 danluu