Dan Kenigsberg
Dan Kenigsberg
A casual reader finds it hard to understand what is "false" in WithCloudInitNoCloudNetworkData(networkData, false) This can be solved by introducing a named argument or even an enumeration for encoding. However,...
/kind bug For KubeVirt users, xml is an implementation detail. IMHO we should have a very good reason to mention it in a functional test, and I feel that too...
This is a follow-up to https://github.com/kubevirt/kubevirt/pull/7114/files#r797663204 ; I believe that now it is possible to drop the two remaining storage-related cases from the console test. console_test should test only console...
Make vmi_ignition_test shorter and clearer by using `libvmi` to define a VM and by reusing `RunVMIAndExpectLaunch` instead of re-implementing it. Furthermore, have the test verify that the requested ignition data...
Use precise name for an internal link in our SECURITY page. ```release-note NONE ```
Seeing the error message admission webhook "datavolume-validate.cdi.kubevirt.io" denied the request: target resources requests storage size is smaller than the source I found it difficult to understand what was wrong in...
/kind enhancement qemu images may be garbled en route from an http server to CDI's target. To identify this condition, many servers (e.g. [Fedora](http://mirror.isoc.org.il/pub/fedora/releases/32/Cloud/x86_64/images/Fedora-Cloud-32-1.6-x86_64-CHECKSUM) provide the expected checksum of the...
RandTmpDir() was used only to generate a path for HostDisk. I don't think that the tests that use it should exist as e2e test, but I do not address this...
The minimal memory size of Cirros and Alpine operating systems is currently needed by multiple tests. Let us expose it in libvmifact. ```release-note NONE ``` /sig code-quality