Danilo Campana Fuchs

Results 28 comments of Danilo Campana Fuchs

Please @miyakogi, could you please take a look? This is breaking for many users and has a simple fix.

@michaelwittig currently on `getAlpha3Code`, `getName`, etc. when the lib cannot find the corresponding country, it returns `undefined`. This is currently not expressed with the current `index.d.ts` file. So, this PR...

When using Typescript (or any preprocessor like Babel), you have to execute a command to generate output `.js` files before running `npm publish`. Usually, that would be `npm run build`

@KingDarBoja I'm not sure I liked the convertion of locale files from JSON to TS. JSON is easier for beginners to use and many open PRs are made based on...

Nice! I will write some PRs. Tell me what you think about it.

Why would this be a breaking change? It makes the assertions more useful for debugging, but does not affect the assertion itself. A test that does not pass will continue...

Hi, I would like to help migrating `cache` or `serialize`. A merge from master would be required so we don't migrate stale code or introduce regressions. Migrating everything at once...

Keeping the `dtslint` tests during migration is very useful to make sure the TS public interface is not being changed in the process. I myself caught a missing export when...

I agree TS 3.8 seems like a safe choice. TS rarely introduces breaking changes, so users of older versions might be able to upgrade easily. TS does allow emitting multiple...

The way I accomplished through a custom Selector was to create a svg element on top of Annotation and then create paths that follow the datapoints.