Daniel Weck issues

Results 315 issues of


                                            Daniel Weck

delete single bookmark in list (while in edit mode or not) causes crash (works fine with annotations editor)

"focus" keyboard shortcuts do not focus in Thorium3 (works in Thorium2)

These do not work: https://github.com/edrlab/thorium-reader/blob/c8965b3a4c62ea75645aa0b8a6001aee5b25ac15/src/common/keyboard.ts#L72-L95 Related issue: https://github.com/edrlab/thorium-reader/issues/2303 This still works: https://github.com/edrlab/thorium-reader/blob/c8965b3a4c62ea75645aa0b8a6001aee5b25ac15/src/common/keyboard.ts#L111-L116 https://github.com/edrlab/thorium-reader/blob/c8965b3a4c62ea75645aa0b8a6001aee5b25ac15/src/common/keyboard.ts#L40-L45 https://github.com/edrlab/thorium-reader/blob/c8965b3a4c62ea75645aa0b8a6001aee5b25ac15/src/common/keyboard.ts#L53-L64

pagination selector is editable (arbitrary text can be entered)

like keyboard shortcut editor, annotation editor should tab-cycle and lock keyboard, otherwise confusing screen reader experience

Publication metadata link can be mouse clicked but not ENTER key triggered (not keyboard accessible, though screen readers can emulate the click event)

Thorium 2.4.x : on MacOS (probably other OS too) mouse click + mod keys on React router links in GUI trigger new blank window or download (e.g. localhost in dev, library_index.html in prod)

@panaC we observed this in Thorium3 too, probably a React Router breaking change (event.preventDefault() handling). So, we can't fix this in 2.4.x but we have to make sure this doesn't...

Daniel Weck

delete single bookmark in list (while in edit mode or not) causes crash (works fine with annotations editor)

"focus" keyboard shortcuts do not focus in Thorium3 (works in Thorium2)

pagination selector is editable (arbitrary text can be entered)

like keyboard shortcut editor, annotation editor should tab-cycle and lock keyboard, otherwise confusing screen reader experience

Publication metadata link can be mouse clicked but not ENTER key triggered (not keyboard accessible, though screen readers can emulate the click event)

some OPDS "buttons" / GUI controls only activate with enter key, not space bar (are they "a" instead of "button" tags?)

OPDS navigation trail keeps growing...what heuristics could we used to "replace last" instead of "append"?

OPDS navigation trail is prematurily condensed / shortened

Thorium 2.4.x : on MacOS (probably other OS too) mouse click + mod keys on React router links in GUI trigger new blank window or download (e.g. localhost in dev, library_index.html in prod)

minor(?) GUI nitpick, the LCP passphrase text input field has an icon on the left hand side, visually looks just asterisks => confusing