Daniel Weck

Fixes https://github.com/readium/readium-js-viewer/issues/467

Migrate from jQuery 2 (used in shared-js etc.) to v3 (used in CFI lib)

8

https://blog.jquery.com/2016/06/09/jquery-3-0-final-released/ https://jquery.com/upgrade-guide/3.0/

CFI blacklist (element, class, id)

2

Related issue: https://github.com/readium/readium-js-viewer/issues/278 The CFI library currently doesn't expose an API to easily customize blacklists across the board (i.e. for all the features that rely on CFI interpretation/generation). There are...

https://github.com/readium/readium-cfi-js/blob/master/readium-build-tools/versionsMaker.js#L155 https://github.com/readium/readium-js-viewer/blob/develop/epub_content/epubReadingSystem/EPUB/index.xhtml#L155

Support for OPF spine item indexing: initial CFI path prefix using even numbers for XML nodes (OPF), before indirection into DOM tree (XHTML)

6

Does this library support "full" CFI expressions starting in the OPF (spine items), or only "partial" CFI syntax (local to the DOM of a HTML document)? My impression is: the...

Text range across MathML (transform to SVG via MathJax), does it work fine?

1

Related issue (images): https://github.com/readium/readium-shared-js/issues/101

This is not a bug report, but a reminder to check whether we are "doing the right thing" in our CFI generator / processor code, and in the "annotations" (highlighter)...

[security good practice] GitHub Action workflow, secrets.GITHUB_TOKEN now restricted by default (was permissive)

2

Please update your GitHub Action workflow YAML to include the `permissions` key and explicitly specify the read/write access rules your jobs actually require: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

Tests for manifest item fallback, unclear expected outcome

5

https://github.com/w3c/epub-tests/blob/9a023cea6d7a34fdce86b28e8f443a8c913f0fd5/tests/pub-foreign_bad-fallback/EPUB/package.opf#L20-L27 In this case, the resulting reading order (i.e. computed spine, once the fallback chain is resolved) is empty if the reading system follows the cascade of unsupported media types....

https://w3c.github.io/pwpub/