Daniel Shahaf

Forward compatibility: a theme written for 0.5.0 might not define styles introduced in 0.6.0. Ensure the design handles this. As an extreme example, an empty theme (simply `touch themes/empty.zsh; ZSH_HIGHLIGHT_THEME=empty`)...

Once that's merged, we could migrate the test suite to run under a theme that has ZSH_HIGHLIGHT_STYLES as the identity mapping. Or, as Matthew points out, at least an injective...

The branch has a merge conflict due to 30d8f92df2258c263185ede09925fef3fa47019c on master.

Once this is merged, ~~I~~we should probably add a screenshot of the `error-only` theme to README. [The existing screenshot uses Inconsolata 24; the new screenshot should probably do the same...

Do you want to cherry-pick d8411a6 to master now? It's a flag day change, so we'll both have headaches down the road if tests are changed on master before that...

In _zsh_highlight_load_theme(), how about changing `source $foo` to `source $foo --`, to make it easier to extend the driver-to-theme interface in the future with positional arguments? afe869ddc0a5491c42008039d2ec66c8a45ac6e8 needs to use...

As the code stands, a missing key will result in https://github.com/zsh-users/zsh-syntax-highlighting/blob/31ac2b36a9156ef424e8ccee560ec31f97bd3eef/highlighters/main/main-highlighter.zsh#L80 being executed with `[[ $style == '' ]]`, won't it? That would append an invalid value to $region_highlights: an...

> As the code stands, a missing key will result in https://github.com/zsh-users/zsh-syntax-highlighting/blob/31ac2b36a9156ef424e8ccee560ec31f97bd3eef/highlighters/main/main-highlighter.zsh#L80 being executed with `[[ $style == '' ]]`, won't it? This is also discussed in https://github.com/zsh-users/zsh-syntax-highlighting/issues/287#issuecomment-204843028 et seq,...

Forward compatibility: how should we handle the case of a theme written for 0.5 and used with 0.6, where 0.6 defines new token classes ($ZSH_HIGHLIGHT_STYLES keys)? _edit:_ Such as the...

1. With the proposed implementation, highlighters will only be able to install hooks for explicitly-enumerated themes. I'd rather enable highlighters to have `if [[ $theme == (foo|bar|bazv) ]]` style handling...