Daniel Shahaf

Results 357 comments of Daniel Shahaf

@romkatv This looks great; thanks a lot! @phy1729 Could you liaise with Roman regarding getting both this and #758 merged? They're both pretty large diffs and I'd like not to...

Milestoning 0.8.0 for review purposes. (Not expressing an opinion about whether we should release 0.8.0 before or after this is merged.)

Context for the release timing question: We merged redrawhook last week, which was the main release blocker, and the merge went well, so I for one was in a "let's...

> I don't have an opinion on the matter of release timing. I'll defer to your judgement. Ack, thanks. > I believe the vast majority of users are following `master`...

Thanks! (But have no time for more than that right now)

Sorry for the latency. > > I can't explain the `0` output in the "default option settings" case. Isn't it a bug? > > Looks like a bug. Would you...

> I've made another performance improvement that affects highlighting of commands with an alias in command position. PTAL. Will do, but it may be a few days. Cheers!

Sorry about the bad estimate in the last comment; life got ahead of me. In other news, 62c5575848f1f0a96161243d18497c247c9f52df, which I cherry-picked earlier, has been reverted due to breaking tests. @romkatv...

Could do it that way too. It's just there's a bunch of changes already in for days so I wondered whether to split the release cycle so as to get...

For clarity, I'm not proposing any change to the schedule for merging and releasing redrawhook: the dates on which it will be merged and released don't depend on whether the...