Daniel Schäufele
Daniel Schäufele
I'm working on a fix for this issue. My proposal would be to add `cyclic_prefix_length_first_symbol` and `symbols_per_half_subframe` as parameters to `OFDM(De)Modulator` and as a property to `CarrierConfig`. The algorithm of...
Hi @naperman, I have created a fork [here](https://github.com/danielschaeufele/sionna), which fixes these issue and makes the code compatible to the 3GPP standard. Please let me know if you have any issues...
Hi @naperman, I didn't do any explicit link level simulations, but the test in `test/unit/nr/test_pusch_receiver.py` performs simulations with both `TimeChannel` and `OFDMChannel` and both work fine. There is one small...
Hi @naperman, As far as I know there currently is no way to generate multiple slots with a single `PUSCHTransmitter` object. So far I was lucky enough to use transform...
Hi @jhoydis, I think another issue will be that not every slot has the same number of time domain samples, because for SCS > 30KHz, not every slot has the...
There is #465, which will hopefully be merged soon. This will at least generate the correct cyclic prefix length. However, this won't help with generating multiple slots at once. I...
I just noticed an issue with my code. The assumption that the first symbol in a slot has a longer cyclic prefix is not always valid. For example with SCS...
FYI: I just did a complete rewrite of my implementation. Instead of passing the length of long and normal cyclic prefixes and the periodicity of the long cyclic prefix, I...
Hi @jhoydis, I updated my code to work with the new release. The problem with `RessourceGrid` is still open, but this can also be fixed at a later time, because...
Yes, it wasn't merged yet (and it is unlikely that it will be merged in the future). In the meantime you can install my version from here: https://github.com/danielschaeufele/sionna/tree/main