Daniel Roe comments

Results 2592 comments of


                                            Daniel Roe

Error when testing with @nuxtjs/test-utils

That sounds like it might be a `@nuxt/test-utils` issue indeed!

chore: also run ecosystem ci on windows

thank you! if any of these are reproducible in the module’s main repo we should probably add a windows workflow there as well

chore: also run ecosystem ci on windows

indeed I could … just not sure how welcome it would be 😆

chore: also run ecosystem ci on windows

Happy to do it, but I think we should - [ ] make the os a selection for on demand test - [ ] ensure that the os is printed...

Improved Character Range and Special Sequence Support

what do you think of the implementation in https://github.com/unjs/magic-regexp/pull/399?

feat: add warning if some preset import is overridden

sorry for directly pushing - I tried to move as much of the calculation out of `regenerateImports` for performance reasons. I've also moved it after `imports:extend` so we catch all...

feat: add warning if some preset import is overridden

You're right, we should still pay attention to priority.

ci: fix build-head size failure for forks

oops. too hasty an approval. still, thank you for looking at this

ci: fix build-head size failure for forks

thank you! if you're happy to leave this PR open, I can experiment a bit with it

ci: fix build-head size failure for forks

weirdly, this still seems to be failing.