ecosystem-ci icon indicating copy to clipboard operation
ecosystem-ci copied to clipboard

chore: also run ecosystem ci on windows

Open tobiasdiez opened this issue 1 year ago โ€ข 4 comments

๐Ÿ”— Linked issue

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation or readme)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [ ] ๐Ÿ‘Œ Enhancement (improving an existing functionality)
  • [x] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Sometimes I run in errors that are specific to windows. Perhaps this is because most of the core developers in the nuxt ecosystemu seem to use linux/macos and the ci tests in the repos are also usually only run on ubuntu.

It would be nice if such errors could be discovered before and not after a new release of a module/nuxt version. For this reason, we activate the ci-ecosystem tests also on windows.

Test run (3.x branch): https://github.com/tobiasdiez/ecosystem-ci/actions/runs/11026454120 Test run (main branch): https://github.com/tobiasdiez/ecosystem-ci/actions/runs/11026329086

There are a few modules that are indeed broken on Windows (but not on ubuntu). Most of these issues seem to be due to https://github.com/nuxtlabs/nuxt-component-meta/issues/72.

tobiasdiez avatar Sep 25 '24 05:09 tobiasdiez

thank you!

if any of these are reproducible in the moduleโ€™s main repo we should probably add a windows workflow there as well

danielroe avatar Sep 25 '24 05:09 danielroe

if any of these are reproducible in the moduleโ€™s main repo we should probably add a windows workflow there as well

I can at least reproduce the issue coming from nuxt-component-meta in the storybook module (https://github.com/nuxt-modules/storybook/pull/775). I agree, it would make sense to run windows-based workflows in each of the modules themselves. Is this something you can create mass-PRs for using your magic tools? ๐Ÿ˜„

tobiasdiez avatar Sep 25 '24 08:09 tobiasdiez

indeed I could โ€ฆ just not sure how welcome it would be ๐Ÿ˜†

danielroe avatar Sep 25 '24 10:09 danielroe

Happy to do it, but I think we should

  • [ ] make the os a selection for on demand test
  • [ ] ensure that the os is printed (maybe via emoji) in discord webhook
  • [ ] we can then make the test scheduled once everything is green

danielroe avatar Sep 26 '24 18:09 danielroe