danielrainer

> I definitely prefer the CMake build system, as it's very easy for Fedora to correctly build and install things with it, as we have a reliable pattern for CMake....

That's fair. We are moving away from external dependencies, so I don't think much probing that's not already happening in Rust will be required in the future. Regarding installation, I...

The issue with skipping is that nearby code which should be formatted would be skipped as well. E.g. i noticed this issue because `src/tokenizer.rs` has some tabs in lines 425...

Long string literals will no longer prevent formatting if we switch to the 2024 style edition: https://doc.rust-lang.org/edition-guide/rust-2024/rustfmt-formatting-fixes.html#long-strings-dont-prevent-formatting-expressions

> Though from a quick glance at `cargo fmt -- --config=error_on_unformatted=true`, I didn't see any long string literal that causes such an error. Hm, yes, the errors printed by that...

I ran into the same issue and opened https://github.com/fish-shell/fish-shell/discussions/11682, but I don't have a solution to the issue. For now, I use aliases in my jj config, which works with...

```fish abbr --add jj_subcommand --command jj --function _jj_subcommand --regex '\S+' function _jj_subcommand set -l subcommand (string match --groups-only --regex '^jj\s+(\S+)\b' (commandline)) switch $subcommand case c echo commit case d echo...

If you combine it with jj aliases, expansion will work most of the time, but when it doesn't the unexpanded subcommand will still work.

Good catch, thanks for pointing it out. I edited the code so it's easier to find for others.

Looking at `printf` it seems that the its current semantics are incompatible with explicit argument positions due to: > The FORMAT argument is re-used as many times as necessary to...