danielrainer

Results 62 comments of danielrainer

> `complete myapp -s f -l foo -d (_ complete_myapp_flag_foo_desc)` For cases where we currently don't have explicit localization requests we could possibly hack together some auto-ID-generation and extract the...

For `mktemp` specifically, I've also recently thought about how it can be used or replaced, in the context of writing a Rust binary which checks some of our source files....

I haven't looked into what the test does yet, so I don't have anything to say about that. The failure occurred a second time, again disappearing on the next test...

This won't run in CI until `check.sh` is used there, so technically installing the package in CI is useless for now. But once we switch to that ShellCheck should just...

> I'd also expect that "rg" has an option to ignore ".git" directories `--no-ignore-exclude` might be what we want. The naming is a bit confusing, but the docs say: >...

I implemented a list tracking which files should be shellchecked, plus a script for updating the list and checking if it is outdated, plus a way to locally ignore files....

Typo in commit message: "Coomand name too long" -> "Command name too long"

As https://github.com/fish-shell/fish-shell/issues/11788#issuecomment-3272934232 mentions, there is still the problem that the overly long command is prefixed with a directory. We should either fix this now or open a separate tracking issue...

Otherwise, I approve of these changes, thanks for contributing. One additional peculiarity I noticed is that changing ```fish $fish -c 'set x (string repeat 1000 x); $x' ``` to ```fish...

The new commits run `cargo run --package fish-fluent-check` in `check.sh` and CI. I added it as separate jobs because running cargo in a test started from the test driver is...