connected-next-router icon indicating copy to clipboard operation
connected-next-router copied to clipboard

Published 20 hours ago • verified publisher icon danielr18

Router Middleware Improvements

Open laooola opened this issue 3 years ago • 4 comments

Improvements

  • [x] use store.dispatch to actually dispatch the LOCATION_CHANGE action (so all middlewares are able to process the action; the sequence of applied middlewares does not matter anymore)

laooola avatar Nov 25 '20 12:11 laooola

@danielr18 here's the improvement I was talking about

laooola avatar Nov 25 '20 12:11 laooola

Would this change essentially prevent issues where redirects occur and trigger side-effects through redux-saga using '@@router/LOCATION_CHANGE'?

kylemh avatar May 12 '21 16:05 kylemh

@kylemh I don't think it would make a difference for that, care to explain the issue you are seeing?

danielr18 avatar May 12 '21 16:05 danielr18

No issue! Basically doing the last bit of our migratory work from when I last commented, and we're finally ditching all of react-router. This PR just made me worried there is an issue.

kylemh avatar May 12 '21 16:05 kylemh