danielpeintner

findProtocol SHOULD NOT require base

4

> This is done in node-wot at https://github.com/eclipse-thingweb/node-wot/blob/master/packages/td-tools/src/td-helpers.ts#L27 a bit but in general, this kind of code should be in node-wot or td-tools _Originally posted by @egekorkan in https://github.com/eclipse-thingweb/node-red/pull/16#discussion_r1568038154_

Node.js 22 is now available! see https://nodejs.org/en/blog/announcements/v22-release-announce We might want to add it to our CI tests in https://github.com/eclipse-thingweb/node-wot/blob/master/.github/workflows/ci.yaml

[td-tools] - 'webpack' is not recognized as an internal or external command

1

Recently I noticed the following issue when running `npm run build` in the `/packages/td-tools/` folder ``` > tsc -b && webpack 'webpack' is not recognized as an internal or external...

emitPropertyChange merges payloads - race condition?

1

> That would mean that when emitPropertyChange is called both if statements are true: Just to be precise, it is the emitEvent that is the issue. I am only sending...

Revert PR#1188 once solved in node-coap

1

> Also I'd add a followup issue to revert the change once it is solved in node-coap. That sounds good! _Originally posted by @JKRhb in https://github.com/eclipse-thingweb/node-wot/issues/1188#issuecomment-1849622438_

PR 1186 follow-ups w.r.t. validation

1

> I think we can merge this PR as is and look at some points raised in the comments later > * @relu91 check implementation in browser > * @danielpeintner...

feat(core): add semantic composed thing

4

Based on the work started in https://github.com/eclipse-thingweb/node-wot/tree/semantic-layer I would like to continue working on providing a `SemanticComposedThing` as a wrapper around `ConsumedThing`. The idea is that consumers no longer need...

> Thank you, @danielpeintner, for providing this fix! After also doing some more research, I discovered that the problem might be related to `vm2`, since the error does not occur...

The readme needs some updates * [x] Typo `dempo-opcua1.ts` -> `demo-opcua1.ts` * [ ] Describe how to run it, via TS or shall we switch to JS like we do...

Update folder structure for the package `examples`

1

General comment. At the moment we have the following folder structure for the package `examples` * `bindings` ... okay * `scripts` ... contains most of our "starter" things. Anyhow, name...