Daniel Marin comments

Results 12 comments of


                                            Daniel Marin

Simple `Display` impl doesn't render full output

Wow, strange bug -- possible sources I think: syscall, memory allocator, RISC-V to NVM translation

Prover SDK tracking issue

This looks great

integrate Jolt as secondary prover

This looks great. I'm getting some nasty error about `cargo` for the `1.77.0-aarch64-apple-darwin` toolchain. Which toolchain are you using?

integrate Jolt as secondary prover

Great, it seems we now need unified logging. @sjudson should be able to handle this (if deemed important).

Met an Error of `misaligned memory access` when tried with sqlparser crate

Thanks @silathdiir! Great catch. Might be because of the memory allocator failing to allocate the string as expected by the parser. @govereau or @sjudson, what do you think?

Met an Error of `misaligned memory access` when tried with sqlparser crate

It might be due to the allocator here: https://github.com/nexus-xyz/nexus-zkvm/blob/main/runtime/src/lib.rs

keccak example fails to prove

Interesting, let us investigate this issue. @govereau can you take a look?

Feat: Implement `cargo nexus clean`

Discussed today. TL;DR: @slumber shall decide where to best place the pps.

Fix `[no_std]` `rust_analyzer` error for `cargo nexus new`

Yeah, I found this too while trying to fix it myself. Perhaps it's better to leave it for now. The fake test might be a good option, but this raises...

[FEATURE]: Optimize the size of R1CSShape of PublicParams

@flyq and @taint160596 yup the R1CSShape encodes (multiple cycles of) the RISC-V machine. Due to folding, the proofs are large, and the public parameters are too. We're working on the...