Daniel Sun

https://sunlan.me

Shanghai, China Apache Groovy PMC member, @GroovyHelp creator, The Definitive ANTLR4 Reference(CN) reviewer, The Definitive Guide to Grails translator, etc.

Results 30 comments of


                                            Daniel Sun

fix GROOVY-9367

Could you add some tests?

fix GROOVY-9367

@blackdrag Agreed :-)

GROOVY-7971: @CS flow typing incorrectly casting to map at runtime

PR #1269 or PR #1293 ?

GROOVY-7971: @CS flow typing incorrectly casting to map at runtime

The PR seems to break Grails joint build: https://github.com/apache/groovy/runs/836663285?check_suite_focus=true

Removed wildcard processing from startGroovy.bat

Merged. Thanks! https://github.com/apache/groovy/commit/a86a4f126914378c801441a2fff48917ae958cbb

Field version of Tuple1, ... , Tuple9

Merged with some tweaks. Thanks! https://github.com/apache/groovy/commit/0dd461d673db9dc6e9d13013e90936b0f067562b

Consider using rule versioning to associate code with grammar rules

The parser project is quite large. Rule versioning looks good. Glad to get your help to adopt the feature :-)

Consider using rule versioning to associate code with grammar rules

Apart from the code maintenance, could you please provide me some advice to improve the performance further?

Consider using rule versioning to associate code with grammar rules

OK

Consider using rule versioning to associate code with grammar rules

@sharwell ping :-)

1
2
3
›