Daniel Scott

👍 Would be great to get this fixed. Anything I can do to help?

I just saw that the `finally` block with `t.cancel()` was removed by this PR: https://github.com/awslabs/aws-cloudformation-templates/commit/67d4f2a8244fee0d6c44c6788f2bd7e83ae25428#diff-caf0cd039f3147afdf4f64683b74dad7 Should it be restored?

That will help! I've encountered some other issues to do with logging: https://forum.serverless.com/t/python-lambda-logging-duplication-workaround/1585 Might be nice to include this fix too.

2nd option is probably better? If we can avoid hanging stacks, that would be best.

Is there a workaround for this? I'm trying to get the module working with Amazon's python27 packages.

> Hi @danieljamesscott! Thanks for opening this PR! I'm not opposed to adding this feature but I think there are some things to think through before we can merge. Great....

> You can currently add job level defaults to any `JobStep` via the `defaults` property: > > https://github.com/cdklabs/cdk-pipelines-github/blob/ad882b9d2e311c427d3a91a3236c0af5c6999546/src/workflows-model.ts#L90 > > There is also a `JobSettings` property on the `GitHubWorkflow` construct...

@kaizencc , would you consider a PR to implement the above?

> the GitHub OIDC role must be created separate to the pipeline and its arn must be passed in after it has been created. Please can you explain why this...

> > the GitHub OIDC role must be created separate to the pipeline and its arn must be passed in after it has been created. > > Please can you...