Daniel Jacobs
Daniel Jacobs
Quoting from the PR: > full-screening the content with the context menu always works, but only changes the `displayState` if `allowFullScreen` is true.
Supersedes https://github.com/ruffle-rs/ruffle/pull/3511 when merged
For what it's worth, the Ruffle Flash emulator would benefit a lot from an API like this. As the name implies, we're emulating Adobe Flash Player, which had two ways...
It would be nice to have this merged sooner than later so Ruffle bumping indicatif in https://github.com/ruffle-rs/ruffle/pull/22271 doesn't end up duplicating the console dependency. We will have to bump indicatif...
Relates to #7868
References: `xmlns`: https://developer.mozilla.org/en-US/docs/Web/SVG/Namespaces_Crash_Course#declaring_namespaces `fill`: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/fill and https://svgwg.org/svg2-draft/painting.html#FillProperties `d`: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/d and https://svgwg.org/svg2-draft/paths.html#DProperty `autocorrect`: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#autocorrect `autocapitalize`: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/autocapitalize and https://html.spec.whatwg.org/multipage/interaction.html#attr-autocapitalize
I created these type definitions to try to work around the issue: ```tsx interface SVGSVGElement { xmlns?: string; // Works scale?: string | number; // Works } interface SVGPathElement {...
~Somehow, with no other changes to `globals.d.ts`, this is all that's needed, no matter how many property errors I'm getting with this package before that change:~ ~`declare module "tsx-dom-types" {...
So the issue seems three-fold: 1) Properties defined only on SVGAttributes but not HTMLAttributes don't work without changing the type definitions for the element interfaces to add the properties there...
Ah yeah, that works (fixes number 3 from https://github.com/Lusito/tsx-dom/issues/22#issuecomment-2237461126). So this is my new working `globals.d.ts` file: ```ts import "tsx-dom-types"; declare module "tsx-dom-types" { export interface HTMLAttributes { autocapitalize?: string;...