insta icon indicating copy to clipboard operation
insta copied to clipboard

Upgrade `console` to `0.16.0`

Open zanieb opened this issue 5 months ago • 7 comments

See https://github.com/console-rs/console/releases/tag/0.16.0 / https://github.com/astral-sh/uv/pull/14890

See also https://github.com/mitsuhiko/similar-asserts/pull/14 for removing 0.15.4

zanieb avatar Jul 25 '25 16:07 zanieb

I would have proposed this when I patched the dependency in the Fedora package, rust-insta and opened https://github.com/astral-sh/uv/pull/14890, but I saw that the insta crate still supports Rust 1.64.0, and that console bumped their MSRV to 1.66 sometime after console 0.15.4, which is the version in Cargo.lock. I don’t know how that MSRV was chosen or whether it is time to consider raising it.

musicinmybrain avatar Jul 26 '25 11:07 musicinmybrain

👍 I'll admit I did not check the MSRV

zanieb avatar Jul 26 '25 20:07 zanieb

how viable would it be to have an MSRV for cargo-insta of 1.66, without bumping MSRV of insta?

we just bumped the overall MSRV to 1.64, so am hesitant to bump it up further; @mitsuhiko has always been keen on compat

alternatively, can we support 0.15 & 0.16? then we're less likely to be holding any other libraries back...

max-sixty avatar Aug 05 '25 02:08 max-sixty

For what it's worth, I'm not in a huge rush here. It's just wasteful to compile the crate multiple times. I also think insta feels fairly stable and blocking upgrade on MSRV doesn't seem like a big deal, but 🤷‍♀️

zanieb avatar Aug 05 '25 12:08 zanieb

alternatively, can we support 0.15 & 0.16? then we're less likely to be holding any other libraries back...

I don't think that's possible: the std feature was added in 0.16 so a simple version range won't work.

dpaoliello avatar Sep 08 '25 17:09 dpaoliello

It would be nice to have this merged sooner than later so Ruffle bumping indicatif in https://github.com/ruffle-rs/ruffle/pull/22271 doesn't end up duplicating the console dependency. We will have to bump indicatif to address https://rustsec.org/advisories/RUSTSEC-2025-0119, as the old version of indicatif, in addition to depending on console 0.15.x, depends on number_prefix.

danielhjacobs avatar Nov 19 '25 16:11 danielhjacobs

maybe we have a policy of 3 years MSRV for the core insta crate? that would let us bump to 1.64

@zanieb do you want to make that change in this PR or would you feel more comfortable if we did it separately?

max-sixty avatar Nov 19 '25 22:11 max-sixty