Daniel Guillan

Results 28 comments of Daniel Guillan

We recently [merged some changes](https://github.com/primer/brand/pull/767) that reverse the order of the content and visuals on small viewports which should have solved the possible confusion about which copy and images are...

The different colors were intentional but purely aesthetic choices based on the page designs these components supported when they were introduced. I also recommend updating these to use blue by...

Yes, the CTA Banner component currently supports setting a background color using the `--brand-CTABanner-bgColor` custom property. We could consider adding a new `backgroundColor` property to align it with [BreakoutBanner](https://primer.style/brand/components/BreakoutBanner/react#component-props), which...

#### Smoke test results - Improved support for React v19 🟢 No issues, regressions, or new console warnings observed. All tests and type-checks were successfully run for all packages using...

I think we can leverage the styles of the updated `subtle` Button variant: ![Logosuite pause button in light and dark mode](https://github.com/user-attachments/assets/9225a138-23ab-47ba-bc99-e39dbae5754e) We also need a `40px` offset at the end...

Thanks for the report, @seangolob! This is a quick fix, so we'll include a fix in the next release.

Hey! @seangolob, regarding the `as={undefined}` issue, we're curious why you need to set the value to `undefined` instead of simply omitting the prop, which would render the correct heading level....

From Primer Brand office hours: decision to introduce a spacing control prop with a `condensed` option. Reference page: https://github.com/enterprise/contact