Daniele Lerede
Daniele Lerede
Yes @ekatef . Indeed it wasn't a problem related with the script. In any case, it would be beneficial to add some checks in the `build_powerplants.py` script to avoid a...
The changes in data/costs.csv are needed to align results of the tests with the previous version. I added the "further description" header to uniform with the standard structure of cost...
Hi @ekatef sorry is there anything still needed to adjust here? :)
Hi @ekatef ! thanks for the review! Concerning point 1, I fixed the pre-commit! Regarding point 2, I think I don't have the permissions to update the pinned environment, but...
Hi @ekatef I added a fallback default exchange rate in case of failure in the use of currencyconverter!
Hi @ekatef thank you! Not sure if the environment issue has been completely fixed with #1458 . In that case maybe we can proceed with the CI tests :)
Hi @ekatef after the solution of environment issues the CI was failing again for all of the OS. The problem was that `currencyconverter` was not included in the lock files...
Hi @ekatef yes, yesterday I had a very immersive experience in understanding what was going on with the CI :laughing: a bit frustrating sometimes but definitely good to build some...
@ekatef looks like the latest update to `workflow/tests.yml` solved the CI failure for Windows too (I really didn't expect that)
Sure @ekatef ! The only needed addition at this point should be the `conda-lock.yml` file, useful to manage those pip dependencies that cannot be managed by the lock files related...