Daniel Deidda
Daniel Deidda
yes I will do that
I have tried to call set_bin_value() with openMP and get seg fault. You could make that critical but then is as slow as without OMP.
is the following included in the STIR 4.0? Author: Daniel Deidda Date: Thu Apr 2 11:51:03 2020 +0100 ProjDataFromStream, adding set_bin_value, fixing #462: (#469) * ProjDataFromStream: added set_bin_value(Bin) * ProjDataInMemory:...
> > > ah. sorry. this was merged on `master`. > > I think best thing to do is to merge release_4 onto master, and you can work from there....
no this was done
> I'd take the opportunity to remove `get_fan_info` from `ML_norm.h` and make it a `static` function. (It's just a convenience function here. shouldn't be used by anybody else). get_fan_info is...
also if get_fan_info goes back to original we will trigger this: ``` if (proj_data_info_ptr == 0) { error("Can only process not arc-corrected data\n"); } ```
those condition were already removed from get_fan_info but the error is triggered when doing the bit the was originally there: ``` proj_data_info_ptr = dynamic_cast(&proj_data_info); ``` ``` if (proj_data_info_ptr == 0)...
> Add a test case to `test_ML_norm.cxx`. should be trivial you mean the same as `test_proj_data_info(shared_ptr proj_data_info_sptr)` but for blocksOnCylindrical?
actually not sure but it works for blocks on cylindrical