Daniel Deidda

Results 56 comments of Daniel Deidda

Actually it seems even the following: `template_proj_data_info_ptr.reset(template_proj_data_ptr->get_proj_data_info_sptr()->clone());` line 214 contains ProjDataInfoCylindrical which it should not for SPECT

> > > @danieldeidda let me know if you cannot push to this branch it seems I cannot push

> > > > > @danieldeidda let me know if you cannot push to this branch > > > > > > it seems I cannot push > > seems...

with these changes it compiles, now i need to try with the data

https://github.com/UCL/STIR/blob/7e0282f0593c0eef157b5e99d8f05eb9504c74dc/src/recon_buildblock/BinNormalisationFromECAT8.cxx#L676 this expects ring1 and ring2 in input. is there a way to get ring1 and ring2 from bin?

using the axial effect we have the following normsino (segment 0) the bottom is without the axial effects ![image](https://user-images.githubusercontent.com/17123621/89399175-0282e900-d70a-11ea-805a-5d2e3d24494e.png)

> > > great. that's looking more realistic! Are we getting closer to the output of e7tools? Not exactly! there is also a big difference in scale ![image](https://user-images.githubusercontent.com/17123621/89401599-6c50c200-d70d-11ea-898f-b5b4a89354e1.png)

> @danieldeidda I've fixed a bug here I believe (last commit), as well as made the norm header parsing much safer/cleaner by moving it to a separate class. Maybe you...

> Can you post the .n.hdr here please? (or even post main diffs with an mMR one, e.g. from the NEMA data). Presumably it's different from an mMR one. If...

And this is the diff output: diff ../../../NEMA_IQ/20170809_NEMA_UCL.n.hdr norm_sinogram/new_norm.n.hdr 1,112c1,109 < !INTERFILE:= < %comment:=CPS ECAT8 sinogram common attributes < !originating system:=2008 < %SMS-MI header name space:=normalization header < %SMS-MI version...