Daniel Brauer

When do you inject vs. just import? (config)

3

My guess is that injecting dependencies is more important when they own resources, but I'm still curious why something like config isn't injected.

Avoid type inference for one parameter

1

I'm trying to use `time stamp` for keyset pagination, and running into problems with precision because it gets converted to a JS Date while in my code, and then back...

Can I use this with number()?

15

This validator looks like what I need, but as soon as I try to put a number in the schema I get horrible errors. Here is reproduction code, just slightly...

Lower Joi dependency

3

Set Joi peer dependency to 15, and fixed generic type parameter as per https://github.com/evanshortiss/express-joi-validation/issues/30#issuecomment-668478275 Also merged `master`

Per-texture filtering/scaling settings

2

### Is there an existing issue for this? - [x] I have searched the existing issues ### What feature are you suggesting? The ability to tell Yuzu how to handle...

Fully automated test run

12

I've barely started using faketorio, but it looks like it always requires manual interaction in order to run tests. Is this true? It would be really nice to have it...

Copy busted's mock, stub and spy API

6

The mocking in faketorio is useful, but it would be awesome if I could use the same API as in my busted tests: https://olivinelabs.com/busted/#spies-mocks-stubs

Look in user's home directory for .faketorio file

1

Uses the HOME environment variable on Unix, and USERPROFILE on Windows. I've tested the former and it works great. Not sure about the latter. I didn't add an automated test...

Look for config file in home directory

4

I think the standard place for a .faketorio file should be in the user's home directory, since it contains information which is not specific to any mod. It would be...

How do I get access to my mod?

3

You have an example where a function `myMod.is_setting_enabled()` gets mocked. How is `myMod` exposed in this case?