Daniel Berkompas

Results 41 comments of Daniel Berkompas
trafficstars

This sounds like it could be a good idea. I was not aware of `:persistent_term` previously. The only downside of using it is that it would require OTP 21.2 or...

Either way, I'd love to see a PR! (Benchmarks comparing it to `:ets` would be nice to have, as well)

@robinvdvleuten thanks for the suggestion! The first step would be to create a `Cloak.Padding` module, similar to the one [in Lockbox](https://github.com/ankane/lockbox/blob/master/lib/lockbox/padding.rb). The `pad/1` and `unpad/1` functions might look something like...

@cybrox @paulstatezny This is actually an issue for the `cloak` package, because that's where this error would need to be implemented. It does already return an error when you call...

Thanks! I've seen this and will review as soon as I can.

I haven't had time to look at this yet. I would like to run some benchmarks before merging though, to get a sense of the improvement, especially since this is...

I have posted a feature request in Ecto's Google group asking for a needed feature to support this: https://groups.google.com/d/msg/elixir-ecto/RbRdj2NFfDI/qsRLz15nAQAJ

Yeah, that's a good suggestion. Overall, I would like to make the API of the package rely less on stores and more on plain old functions.

Hi @silviurosu, I'm currently working on a partial rewrite of the library that will maintain most of the current API, but expose the lower-level functions for direct bulk upload, etc....

I don't think this would necessarily require a lot of effort. Probably, you'd just need to extend the library to accept a new option, similar to `account`. I'm open to...