Dan Allan

Results 752 comments of Dan Allan

Great minds think alike. @jwlodek took care of this: https://github.com/bluesky/tiled/pull/796 We should update the docs to use a more obscure format, so let's leave this issue open.

Hello @Apocalypse96! I don’t immediately recognize your name or GitHub handle. Contributions from anyone are most welcome, but I thought I would just begin by asking whether I ought to...

Sure thing. What brought you to the project?

Anyway, I'd be happy to see you tackle this one @Apocalypse96 if you are interested!

We're down to a tractable number of failures with a hilariously tiny change, pushed above. ``` FAILED tiled/_tests/test_access_control.py::test_entry_based_scopes - AttributeError: 'NoneType' object has no attribute 'execute' FAILED tiled/_tests/test_access_control.py::test_top_level_access_control - AttributeError:...

Rebased on `main` and force-pushed.

This is where we are post-rebase: ``` FAILED tiled/_tests/test_authentication.py::test_refresh_transparent[sqlite_database_uri] - jose.exceptions.ExpiredSignatureError: Signature has expired. FAILED tiled/_tests/test_authentication.py::test_refresh_transparent[postgresql_database_uri] - jose.exceptions.ExpiredSignatureError: Signature has expired. FAILED tiled/_tests/test_authentication.py::test_admin[sqlite_database_uri] - Failed: DID NOT RAISE FAILED tiled/_tests/test_authentication.py::test_admin[postgresql_database_uri]...

I think the next issue is that `tiled.authn_database.connection_pool` makes reference to the global-ish `get_settings()`, a FastAPI-recommended pattern that I wish I had ignored, and that this result does not align...

This is where things stand as I set this down. The `None` issue is related to `get_settings()` and `merged_settings` being out of sync, per comment above. ``` FAILED tiled/_tests/test_access_control.py::test_entry_based_scopes -...

Using a Settings object as the way to initialize an app seems right. I am less sure about building a CLI application around it, but open to exploring. We have...